♻️ Refactor and remove React.FC (#1139)

This commit is contained in:
Alejandra
2024-03-28 20:22:28 -05:00
committed by GitHub
parent 802eeeadc9
commit 6874db48b0
17 changed files with 31 additions and 45 deletions

View File

@@ -14,11 +14,10 @@ import {
ModalHeader, ModalHeader,
ModalOverlay, ModalOverlay,
} from "@chakra-ui/react" } from "@chakra-ui/react"
import type React from "react" import { useForm, type SubmitHandler } from "react-hook-form"
import { type SubmitHandler, useForm } from "react-hook-form"
import { useMutation, useQueryClient } from "react-query" import { useMutation, useQueryClient } from "react-query"
import { type UserCreate, UsersService } from "../../client" import { UsersService, type UserCreate } from "../../client"
import type { ApiError } from "../../client/core/ApiError" import type { ApiError } from "../../client/core/ApiError"
import useCustomToast from "../../hooks/useCustomToast" import useCustomToast from "../../hooks/useCustomToast"
import { emailPattern } from "../../utils" import { emailPattern } from "../../utils"
@@ -32,7 +31,7 @@ interface UserCreateForm extends UserCreate {
confirm_password: string confirm_password: string
} }
const AddUser: React.FC<AddUserProps> = ({ isOpen, onClose }) => { const AddUser = ({ isOpen, onClose }: AddUserProps) => {
const queryClient = useQueryClient() const queryClient = useQueryClient()
const showToast = useCustomToast() const showToast = useCustomToast()
const { const {

View File

@@ -14,15 +14,14 @@ import {
ModalHeader, ModalHeader,
ModalOverlay, ModalOverlay,
} from "@chakra-ui/react" } from "@chakra-ui/react"
import type React from "react" import { useForm, type SubmitHandler } from "react-hook-form"
import { type SubmitHandler, useForm } from "react-hook-form"
import { useMutation, useQueryClient } from "react-query" import { useMutation, useQueryClient } from "react-query"
import { import {
UsersService,
type ApiError, type ApiError,
type UserOut, type UserOut,
type UserUpdate, type UserUpdate,
UsersService,
} from "../../client" } from "../../client"
import useCustomToast from "../../hooks/useCustomToast" import useCustomToast from "../../hooks/useCustomToast"
import { emailPattern } from "../../utils" import { emailPattern } from "../../utils"
@@ -37,7 +36,7 @@ interface UserUpdateForm extends UserUpdate {
confirm_password: string confirm_password: string
} }
const EditUser: React.FC<EditUserProps> = ({ user, isOpen, onClose }) => { const EditUser = ({ user, isOpen, onClose }: EditUserProps) => {
const queryClient = useQueryClient() const queryClient = useQueryClient()
const showToast = useCustomToast() const showToast = useCustomToast()

View File

@@ -6,7 +6,6 @@ import {
MenuList, MenuList,
useDisclosure, useDisclosure,
} from "@chakra-ui/react" } from "@chakra-ui/react"
import type React from "react"
import { BsThreeDotsVertical } from "react-icons/bs" import { BsThreeDotsVertical } from "react-icons/bs"
import { FiEdit, FiTrash } from "react-icons/fi" import { FiEdit, FiTrash } from "react-icons/fi"
@@ -21,7 +20,7 @@ interface ActionsMenuProps {
disabled?: boolean disabled?: boolean
} }
const ActionsMenu: React.FC<ActionsMenuProps> = ({ type, value, disabled }) => { const ActionsMenu = ({ type, value, disabled }: ActionsMenuProps) => {
const editUserModal = useDisclosure() const editUserModal = useDisclosure()
const deleteModal = useDisclosure() const deleteModal = useDisclosure()

View File

@@ -21,7 +21,7 @@ interface DeleteProps {
onClose: () => void onClose: () => void
} }
const Delete: React.FC<DeleteProps> = ({ type, id, isOpen, onClose }) => { const Delete = ({ type, id, isOpen, onClose }: DeleteProps) => {
const queryClient = useQueryClient() const queryClient = useQueryClient()
const showToast = useCustomToast() const showToast = useCustomToast()
const cancelRef = React.useRef<HTMLButtonElement | null>(null) const cancelRef = React.useRef<HTMLButtonElement | null>(null)

View File

@@ -1,5 +1,4 @@
import { Button, Flex, Icon, useDisclosure } from "@chakra-ui/react" import { Button, Flex, Icon, useDisclosure } from "@chakra-ui/react"
import type React from "react"
import { FaPlus } from "react-icons/fa" import { FaPlus } from "react-icons/fa"
import AddUser from "../Admin/AddUser" import AddUser from "../Admin/AddUser"
@@ -9,7 +8,7 @@ interface NavbarProps {
type: string type: string
} }
const Navbar: React.FC<NavbarProps> = ({ type }) => { const Navbar = ({ type }: NavbarProps) => {
const addUserModal = useDisclosure() const addUserModal = useDisclosure()
const addItemModal = useDisclosure() const addItemModal = useDisclosure()

View File

@@ -1,8 +1,7 @@
import { Button, Container, Text } from "@chakra-ui/react" import { Button, Container, Text } from "@chakra-ui/react"
import { Link } from "@tanstack/react-router" import { Link } from "@tanstack/react-router"
import type React from "react"
const NotFound: React.FC = () => { const NotFound = () => {
return ( return (
<> <>
<Container <Container

View File

@@ -12,7 +12,6 @@ import {
useColorModeValue, useColorModeValue,
useDisclosure, useDisclosure,
} from "@chakra-ui/react" } from "@chakra-ui/react"
import type React from "react"
import { FiLogOut, FiMenu } from "react-icons/fi" import { FiLogOut, FiMenu } from "react-icons/fi"
import { useQueryClient } from "react-query" import { useQueryClient } from "react-query"
@@ -21,7 +20,7 @@ import type { UserOut } from "../../client"
import useAuth from "../../hooks/useAuth" import useAuth from "../../hooks/useAuth"
import SidebarItems from "./SidebarItems" import SidebarItems from "./SidebarItems"
const Sidebar: React.FC = () => { const Sidebar = () => {
const queryClient = useQueryClient() const queryClient = useQueryClient()
const bgColor = useColorModeValue("ui.white", "ui.dark") const bgColor = useColorModeValue("ui.white", "ui.dark")
const textColor = useColorModeValue("ui.dark", "ui.white") const textColor = useColorModeValue("ui.dark", "ui.white")

View File

@@ -1,6 +1,5 @@
import { Box, Flex, Icon, Text, useColorModeValue } from "@chakra-ui/react" import { Box, Flex, Icon, Text, useColorModeValue } from "@chakra-ui/react"
import { Link } from "@tanstack/react-router" import { Link } from "@tanstack/react-router"
import type React from "react"
import { FiBriefcase, FiHome, FiSettings, FiUsers } from "react-icons/fi" import { FiBriefcase, FiHome, FiSettings, FiUsers } from "react-icons/fi"
import { useQueryClient } from "react-query" import { useQueryClient } from "react-query"
@@ -16,7 +15,7 @@ interface SidebarItemsProps {
onClose?: () => void onClose?: () => void
} }
const SidebarItems: React.FC<SidebarItemsProps> = ({ onClose }) => { const SidebarItems = ({ onClose }: SidebarItemsProps) => {
const queryClient = useQueryClient() const queryClient = useQueryClient()
const textColor = useColorModeValue("ui.main", "ui.white") const textColor = useColorModeValue("ui.main", "ui.white")
const bgActive = useColorModeValue("#E2E8F0", "#4A5568") const bgActive = useColorModeValue("#E2E8F0", "#4A5568")

View File

@@ -6,14 +6,13 @@ import {
MenuItem, MenuItem,
MenuList, MenuList,
} from "@chakra-ui/react" } from "@chakra-ui/react"
import type React from "react"
import { FaUserAstronaut } from "react-icons/fa" import { FaUserAstronaut } from "react-icons/fa"
import { FiLogOut, FiUser } from "react-icons/fi" import { FiLogOut, FiUser } from "react-icons/fi"
import { Link } from "@tanstack/react-router" import { Link } from "@tanstack/react-router"
import useAuth from "../../hooks/useAuth" import useAuth from "../../hooks/useAuth"
const UserMenu: React.FC = () => { const UserMenu = () => {
const { logout } = useAuth() const { logout } = useAuth()
const handleLogout = async () => { const handleLogout = async () => {

View File

@@ -12,11 +12,10 @@ import {
ModalHeader, ModalHeader,
ModalOverlay, ModalOverlay,
} from "@chakra-ui/react" } from "@chakra-ui/react"
import type React from "react" import { useForm, type SubmitHandler } from "react-hook-form"
import { type SubmitHandler, useForm } from "react-hook-form"
import { useMutation, useQueryClient } from "react-query" import { useMutation, useQueryClient } from "react-query"
import { type ApiError, type ItemCreate, ItemsService } from "../../client" import { ItemsService, type ApiError, type ItemCreate } from "../../client"
import useCustomToast from "../../hooks/useCustomToast" import useCustomToast from "../../hooks/useCustomToast"
interface AddItemProps { interface AddItemProps {
@@ -24,7 +23,7 @@ interface AddItemProps {
onClose: () => void onClose: () => void
} }
const AddItem: React.FC<AddItemProps> = ({ isOpen, onClose }) => { const AddItem = ({ isOpen, onClose }: AddItemProps) => {
const queryClient = useQueryClient() const queryClient = useQueryClient()
const showToast = useCustomToast() const showToast = useCustomToast()
const { const {

View File

@@ -12,15 +12,14 @@ import {
ModalHeader, ModalHeader,
ModalOverlay, ModalOverlay,
} from "@chakra-ui/react" } from "@chakra-ui/react"
import type React from "react" import { useForm, type SubmitHandler } from "react-hook-form"
import { type SubmitHandler, useForm } from "react-hook-form"
import { useMutation, useQueryClient } from "react-query" import { useMutation, useQueryClient } from "react-query"
import { import {
ItemsService,
type ApiError, type ApiError,
type ItemOut, type ItemOut,
type ItemUpdate, type ItemUpdate,
ItemsService,
} from "../../client" } from "../../client"
import useCustomToast from "../../hooks/useCustomToast" import useCustomToast from "../../hooks/useCustomToast"
@@ -30,7 +29,7 @@ interface EditItemProps {
onClose: () => void onClose: () => void
} }
const EditItem: React.FC<EditItemProps> = ({ item, isOpen, onClose }) => { const EditItem = ({ item, isOpen, onClose }: EditItemProps) => {
const queryClient = useQueryClient() const queryClient = useQueryClient()
const showToast = useCustomToast() const showToast = useCustomToast()
const { const {

View File

@@ -7,9 +7,8 @@ import {
Stack, Stack,
useColorMode, useColorMode,
} from "@chakra-ui/react" } from "@chakra-ui/react"
import type React from "react"
const Appearance: React.FC = () => { const Appearance = () => {
const { colorMode, toggleColorMode } = useColorMode() const { colorMode, toggleColorMode } = useColorMode()
return ( return (

View File

@@ -9,18 +9,17 @@ import {
Input, Input,
useColorModeValue, useColorModeValue,
} from "@chakra-ui/react" } from "@chakra-ui/react"
import type React from "react" import { useForm, type SubmitHandler } from "react-hook-form"
import { type SubmitHandler, useForm } from "react-hook-form"
import { useMutation } from "react-query" import { useMutation } from "react-query"
import { type ApiError, type UpdatePassword, UsersService } from "../../client" import { UsersService, type ApiError, type UpdatePassword } from "../../client"
import useCustomToast from "../../hooks/useCustomToast" import useCustomToast from "../../hooks/useCustomToast"
interface UpdatePasswordForm extends UpdatePassword { interface UpdatePasswordForm extends UpdatePassword {
confirm_password: string confirm_password: string
} }
const ChangePassword: React.FC = () => { const ChangePassword = () => {
const color = useColorModeValue("inherit", "ui.white") const color = useColorModeValue("inherit", "ui.white")
const showToast = useCustomToast() const showToast = useCustomToast()
const { const {

View File

@@ -5,11 +5,10 @@ import {
Text, Text,
useDisclosure, useDisclosure,
} from "@chakra-ui/react" } from "@chakra-ui/react"
import type React from "react"
import DeleteConfirmation from "./DeleteConfirmation" import DeleteConfirmation from "./DeleteConfirmation"
const DeleteAccount: React.FC = () => { const DeleteAccount = () => {
const confirmationModal = useDisclosure() const confirmationModal = useDisclosure()
return ( return (

View File

@@ -11,7 +11,7 @@ import React from "react"
import { useForm } from "react-hook-form" import { useForm } from "react-hook-form"
import { useMutation, useQueryClient } from "react-query" import { useMutation, useQueryClient } from "react-query"
import { type ApiError, type UserOut, UsersService } from "../../client" import { UsersService, type ApiError, type UserOut } from "../../client"
import useAuth from "../../hooks/useAuth" import useAuth from "../../hooks/useAuth"
import useCustomToast from "../../hooks/useCustomToast" import useCustomToast from "../../hooks/useCustomToast"
@@ -20,7 +20,7 @@ interface DeleteProps {
onClose: () => void onClose: () => void
} }
const DeleteConfirmation: React.FC<DeleteProps> = ({ isOpen, onClose }) => { const DeleteConfirmation = ({ isOpen, onClose }: DeleteProps) => {
const queryClient = useQueryClient() const queryClient = useQueryClient()
const showToast = useCustomToast() const showToast = useCustomToast()
const cancelRef = React.useRef<HTMLButtonElement | null>(null) const cancelRef = React.useRef<HTMLButtonElement | null>(null)

View File

@@ -11,22 +11,21 @@ import {
Text, Text,
useColorModeValue, useColorModeValue,
} from "@chakra-ui/react" } from "@chakra-ui/react"
import type React from "react"
import { useState } from "react" import { useState } from "react"
import { type SubmitHandler, useForm } from "react-hook-form" import { useForm, type SubmitHandler } from "react-hook-form"
import { useMutation, useQueryClient } from "react-query" import { useMutation, useQueryClient } from "react-query"
import { import {
UsersService,
type ApiError, type ApiError,
type UserOut, type UserOut,
type UserUpdateMe, type UserUpdateMe,
UsersService,
} from "../../client" } from "../../client"
import useAuth from "../../hooks/useAuth" import useAuth from "../../hooks/useAuth"
import useCustomToast from "../../hooks/useCustomToast" import useCustomToast from "../../hooks/useCustomToast"
import { emailPattern } from "../../utils" import { emailPattern } from "../../utils"
const UserInformation: React.FC = () => { const UserInformation = () => {
const queryClient = useQueryClient() const queryClient = useQueryClient()
const color = useColorModeValue("inherit", "ui.white") const color = useColorModeValue("inherit", "ui.white")
const showToast = useCustomToast() const showToast = useCustomToast()

View File

@@ -2,10 +2,10 @@ import { useNavigate } from "@tanstack/react-router"
import { useQuery } from "react-query" import { useQuery } from "react-query"
import { import {
type Body_login_login_access_token as AccessToken,
LoginService, LoginService,
type UserOut,
UsersService, UsersService,
type Body_login_login_access_token as AccessToken,
type UserOut,
} from "../client" } from "../client"
const isLoggedIn = () => { const isLoggedIn = () => {