From 9f6f8f088bf13164a4f92f3b176ae87876d2a64b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Joel=20P=C3=A9rez?= Date: Tue, 18 Feb 2025 17:53:38 +0100 Subject: [PATCH] =?UTF-8?q?=E2=99=BB=EF=B8=8F=20Replace=20email=20types=20?= =?UTF-8?q?from=20`str`=20to=20`EmailStr`=20in=20`config.py`=20(#1492)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- backend/app/core/config.py | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/backend/app/core/config.py b/backend/app/core/config.py index 2370469..d58e03c 100644 --- a/backend/app/core/config.py +++ b/backend/app/core/config.py @@ -5,6 +5,7 @@ from typing import Annotated, Any, Literal from pydantic import ( AnyUrl, BeforeValidator, + EmailStr, HttpUrl, PostgresDsn, computed_field, @@ -74,9 +75,8 @@ class Settings(BaseSettings): SMTP_HOST: str | None = None SMTP_USER: str | None = None SMTP_PASSWORD: str | None = None - # TODO: update type to EmailStr when sqlmodel supports it - EMAILS_FROM_EMAIL: str | None = None - EMAILS_FROM_NAME: str | None = None + EMAILS_FROM_EMAIL: EmailStr | None = None + EMAILS_FROM_NAME: EmailStr | None = None @model_validator(mode="after") def _set_default_emails_from(self) -> Self: @@ -91,10 +91,8 @@ class Settings(BaseSettings): def emails_enabled(self) -> bool: return bool(self.SMTP_HOST and self.EMAILS_FROM_EMAIL) - # TODO: update type to EmailStr when sqlmodel supports it - EMAIL_TEST_USER: str = "test@example.com" - # TODO: update type to EmailStr when sqlmodel supports it - FIRST_SUPERUSER: str + EMAIL_TEST_USER: EmailStr = "test@example.com" + FIRST_SUPERUSER: EmailStr FIRST_SUPERUSER_PASSWORD: str def _check_default_secret(self, var_name: str, value: str | None) -> None: