🏷️ Add mypy to the GitHub Action for tests and fixed types in the whole project (#655)

Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>

backend/app/api/deps.py

@@ -17,7 +17,7 @@ reusable_oauth2 = OAuth2PasswordBearer(
 )
 
 
-def get_db() -> Generator:
+def get_db() -> Generator[Session, None, None]:
     with Session(engine) as session:
         yield session
 

backend/app/api/routes/users.py

@@ -1,7 +1,7 @@
 from typing import Any
 
 from fastapi import APIRouter, Depends, HTTPException
-from sqlmodel import delete, func, select
+from sqlmodel import col, delete, func, select
 
 from app import crud
 from app.api.deps import (
@@ -189,16 +189,17 @@ def delete_user(
     user = session.get(User, user_id)
     if not user:
         raise HTTPException(status_code=404, detail="User not found")
-
-    if (user == current_user and not current_user.is_superuser) or (
-        user != current_user and current_user.is_superuser
-    ):
-        statement = delete(Item).where(Item.owner_id == user_id)
-        session.exec(statement)
-        session.delete(user)
-        session.commit()
-        return Message(message="User deleted successfully")
+    elif user != current_user and not current_user.is_superuser:
+        raise HTTPException(
+            status_code=403, detail="The user doesn't have enough privileges"
+        )
     elif user == current_user and current_user.is_superuser:
         raise HTTPException(
             status_code=403, detail="Super users are not allowed to delete themselves"
         )
+
+    statement = delete(Item).where(col(Item.owner_id) == user_id)
+    session.exec(statement)  # type: ignore
+    session.delete(user)
+    session.commit()
+    return Message(message="User deleted successfully")