From c8104d8ced1da5f7fa148620ffbca71ccd48a5db Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebasti=C3=A1n=20Ram=C3=ADrez?= Date: Mon, 23 Sep 2024 13:39:54 +0200 Subject: [PATCH] =?UTF-8?q?=F0=9F=94=A5=20Remove=20logic=20for=20developme?= =?UTF-8?q?nt=20dependencies=20and=20Jupyter,=20it=20was=20never=20documen?= =?UTF-8?q?ted,=20and=20I=20no=20longer=20use=20that=20trick=20(#1355)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- backend/Dockerfile | 4 +--- docker-compose.override.yml | 3 --- docker-compose.yml | 4 ---- 3 files changed, 1 insertion(+), 10 deletions(-) diff --git a/backend/Dockerfile b/backend/Dockerfile index bb67c32..223b931 100644 --- a/backend/Dockerfile +++ b/backend/Dockerfile @@ -11,9 +11,7 @@ RUN curl -sSL https://install.python-poetry.org | POETRY_HOME=/opt/poetry python # Copy poetry.lock* in case it doesn't exist in the repo COPY ./pyproject.toml ./poetry.lock* /app/ -# Allow installing dev dependencies to run tests -ARG INSTALL_DEV=false -RUN bash -c "if [ $INSTALL_DEV == 'true' ] ; then poetry install --no-root ; else poetry install --no-root --only main ; fi" +RUN poetry install --no-root ENV PYTHONPATH=/app diff --git a/docker-compose.override.yml b/docker-compose.override.yml index fd99cb5..3792f1f 100644 --- a/docker-compose.override.yml +++ b/docker-compose.override.yml @@ -58,12 +58,9 @@ services: backend: restart: "no" ports: - - "8888:8888" - "8000:8000" build: context: ./backend - args: - INSTALL_DEV: ${INSTALL_DEV-true} # command: sleep infinity # Infinite loop to keep container alive doing nothing command: - fastapi diff --git a/docker-compose.yml b/docker-compose.yml index db168b8..c92d5d4 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -46,8 +46,6 @@ services: image: '${DOCKER_IMAGE_BACKEND?Variable not set}:${TAG-latest}' build: context: ./backend - args: - INSTALL_DEV: ${INSTALL_DEV-false} networks: - traefik-public - default @@ -118,8 +116,6 @@ services: build: context: ./backend - args: - INSTALL_DEV: ${INSTALL_DEV-false} labels: - traefik.enable=true - traefik.docker.network=traefik-public